Attention is currently required from: Nicholas Chin.

View Change

7 comments:

• File ch347_spi.c:

  • Patch Set #4, Line 56: speed

    I think `divisor` might be a better term here, as the values passed to the CH347 divide the referenc […]

    Very reasonable,done.

  • Patch Set #4, Line 72: 0x0

    There isn't really a need to write the speeds in hexadecimal, so just drop the `0x` prefix

    Done

  • Patch Set #4, Line 287: defaulet

    default

    Done

  • Patch Set #4, Line 287: 0x0

    Just use decimal […]

    For practicality, it has been modified to default to 30MHz,done.

  • Patch Set #4, Line 365: M

    I would use MHz for more clarity instead of just M

    Done

  • Patch Set #4, Line 365: defaul

    default

    Done

  • Patch Set #4, Line 365: (60M clock spi)

    I don't think the parenthesis really add any value here; I would just drop them.

    Done

To view, visit change 82776. To unsubscribe, or for help writing mail filters, visit settings.