Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Sergii Dmytruk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58479 )
Change subject: libflashrom,writeprotect: add functions for reading/writing WP configs ......................................................................
Patch Set 34:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58479/comment/3599d703_9f7602c9 PS34, Line 11: a spurious `a`
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58479/comment/0a94607f_f13bb936 PS34, Line 125: FLASHROM_WP_OK = 0, NB. we should unify this across the whole API sooner or later.
https://review.coreboot.org/c/flashrom/+/58479/comment/24decda6_5743a364 PS34, Line 151: excessive empty line
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/5674ad61_45e26c0b PS34, Line 642: struct flashrom_wp_cfg Or `sizeof(**cfg)`
https://review.coreboot.org/c/flashrom/+/58479/comment/8d3d4189_1ba933ec PS34, Line 643: (*cfg) Nit, no parentheses needed.
https://review.coreboot.org/c/flashrom/+/58479/comment/9444f0b3_905b5e56 PS34, Line 717: * has its own WP operations we should use instead. Shouldn't we check the type right away and return an error in case?
Or check inside wp_write_cfg()? Currently it relies on `flash->chip-> bus_type == BUS_SPI` and matching contents of `flash->chip->reg_bits`.
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/9b42faee_09a3fa74 PS34, Line 51: = FLASHROM_WP_OK This is overwritten on the very next line.