Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57942 )
Change subject: internal.c: unify the macro for x86 only code ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57942/comment/10b4a04c_41014f63 PS1, Line 9: #if defined(__i386__) || defined(__x86_64__) nit: To avoid having to escape the `#`, how about:
The #if defined(__i386__) || defined(__x86_64__) guard is commonly used for ...
https://review.coreboot.org/c/flashrom/+/57942/comment/70a7f80f_bb9226cf PS1, Line 11: uses plural: `use`
https://review.coreboot.org/c/flashrom/+/57942/comment/eb8b356c_c9b44a6a PS1, Line 11: platfrom typo: `platform`
Patchset:
PS1: I'd personally use the IS_X86 macro everywhere for consistency, but I don't have a strong preference.
-
Angel Pons (Code Review)