Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen.

Patch set 1:Code-Review +1

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 9: \#if defined(__i386__) || defined(__x86_64__)

    nit: To avoid having to escape the `#`, how about:

     The #if defined(__i386__) || defined(__x86_64__) guard is commonly used for ...

  • Patch Set #1, Line 11: uses

    plural: `use`

  • Patch Set #1, Line 11: platfrom

    typo: `platform`

• Patchset:

  • Patch Set #1:

    I'd personally use the IS_X86 macro everywhere for consistency, but I don't have a strong preference.

To view, visit change 57942. To unsubscribe, or for help writing mail filters, visit settings.