[S] Change in flashrom[master]: chipdrivers: Rename s/erase_sector_stm50/stm50_sector_erase

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Felix Singer.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69047 )

Change subject: chipdrivers: Rename s/erase_sector_stm50/stm50_sector_erase
......................................................................

Patch Set 3:

(1 comment)

File flashrom.c:

https://review.coreboot.org/c/flashrom/+/69047/comment/63ba7f75_fae1c7ce 
PS3, Line 377: STM50_SECTOR_ERASE
> I am wondering if we should go the other way, renaming this to ERASE_SECTOR_STM50, since this would  […]

No, that is just aesthetically making things 'look the same' not making things that have meaning to be consistent.

The aim here is to have a `vendor_` || `protocol_vendor_` || `std_protocol_vendor_` prefix rather than a suffix. The op should be the suffix. So, `JEDEC_thing_erase` || `SPI_thing_erase` etc. The current names are all over the place.