Attention is currently required from: Felix Singer.

View Change

1 comment:

• File flashrom.c:

  • Patch Set #3, Line 377: STM50_SECTOR_ERASE

    I am wondering if we should go the other way, renaming this to ERASE_SECTOR_STM50, since this would […]

    No, that is just aesthetically making things 'look the same' not making things that have meaning to be consistent.

    The aim here is to have a `vendor_` || `protocol_vendor_` || `std_protocol_vendor_` prefix rather than a suffix. The op should be the suffix. So, `JEDEC_thing_erase` || `SPI_thing_erase` etc. The current names are all over the place.

To view, visit change 69047. To unsubscribe, or for help writing mail filters, visit settings.