Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66781 )
Change subject: tree/: Convert flashchip probe func ptr to enumerate ......................................................................
Patch Set 8:
(3 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66781/comment/7f6670b0_dffa6841 PS8, Line 735: */
Comment indentation seems off.
Done. Originally intentional to make it clear.
https://review.coreboot.org/c/flashrom/+/66781/comment/f0c04088_30630b68 PS8, Line 781: probe_func_t *probe_func = lookup_probe_func_ptr(flash->chip);
Why do you look up the function pointer twice?
Resolved, thanks.
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/66781/comment/72ba2eb8_b8b9a97b PS8, Line 226: SPI_ST95,
I'd prefer to have a `PROBE_` prefix, primarily because of the `JEDEC` enum value.
Uff, so many lines. Done
-
Edward O'Callaghan (Code Review)