Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Nikolai Artemiev.

View Change

3 comments:

• File flashrom.c:

  • Patch Set #8, Line 735: */

    Comment indentation seems off.

    Done. Originally intentional to make it clear.

  • Patch Set #8, Line 781: probe_func_t *probe_func = lookup_probe_func_ptr(flash->chip);

    Why do you look up the function pointer twice?

    Resolved, thanks.

• File include/flash.h:

  • Patch Set #8, Line 226: SPI_ST95,

    I'd prefer to have a `PROBE_` prefix, primarily because of the `JEDEC` enum value.

    Uff, so many lines. Done

To view, visit change 66781. To unsubscribe, or for help writing mail filters, visit settings.