Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c ......................................................................
Patch Set 10:
(3 comments)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/410e9962_03cf28e0 PS10, Line 46: struct mec1308_test_data *test_data = current_io->test_data; I think you should add a blank line between decls and code
https://review.coreboot.org/c/flashrom/+/51487/comment/3cbd502a_6226b9c7 PS10, Line 53: MEC1308_SIO_PORT1 Can you not access these values somehow, or are you trying to test that the enums are correct?
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/00779891_f4169476 PS10, Line 92: if (current_io && current_io->outb) Why are these allowed to be NULL?