Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

3 comments:

• File tests/init_shutdown.c:

  • Patch Set #10, Line 46: struct mec1308_test_data *test_data = current_io->test_data;

    I think you should add a blank line between decls and code

  • Patch Set #10, Line 53: MEC1308_SIO_PORT1

    Can you not access these values somehow, or are you trying to test that the enums are correct?

• File tests/tests.c:

  • Patch Set #10, Line 92: if (current_io && current_io->outb)

    Why are these allowed to be NULL?

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.