Change in flashrom[master]: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call to save ...

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )

Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call to save programming time
......................................................................


Patch Set 8:

(6 comments)

https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c 
File ft2232_spi.c:

https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c@402 
PS8, Line 402: 	/* 280 Byte = (9 Byte CMD + 1 Byte WREN) + (9 Byte CMD + 1 Byte op) + 4 Byte Addr
This comment would need an extra tab and could be tidied up. Maybe use:

 /*
  * 270 bytes =
  *   + 9 B (CMD)
  *   + 1 B (WREN)
  *   + 9 B (CMD)
  *   + 1 B (op)
  *   + 4 B (addr)
  *   + 256 B (page data)
  *
  * With op: PageProgram or Erase; CMD: FTDI-Chip commands
  */


https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c@471 
PS8, Line 471: static unsigned char *buf = NULL;
Just make this an array:

 static unsigned char buf[FTDI_HW_BUFFER_SIZE];


https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c@473 
PS8, Line 473: static
Why is `i` static now?


https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c@480 
PS8, Line 480: ftdi
FTDI (and missing a space before the comment closes)


https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c@481 
PS8, Line 481: 4096
Please #define this magic number somewhere


https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c@542 
PS8, Line 542: 		/* Return to get second op (Program or Erase) without resetting buf nor i*/
Why?



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/40477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 8
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Patrick Georgi <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Tue, 19 May 2020 18:29:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment