[M] Change in flashrom[master]: ch341a_spi: Refactor singleton states into reentrant pattern

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72807 )

Change subject: ch341a_spi: Refactor singleton states into reentrant pattern
......................................................................

Patch Set 5:

(17 comments)

Patchset:

PS5: 
I added many cleanups you can do as a follow up patch to make type usage consistent, const correct and modern.

File ch341a_spi.c:

https://review.coreboot.org/c/flashrom/+/72807/comment/664c0111_1089e45e 
PS3, Line 100: i = 0
`size_t i = 0;`

https://review.coreboot.org/c/flashrom/+/72807/comment/27bf8c37_a025c100 
PS3, Line 234: unsigned int i;
delete

https://review.coreboot.org/c/flashrom/+/72807/comment/02bb8f27_97c52287 
PS3, Line 235: i
probably should be `size_t i = 0;`

https://review.coreboot.org/c/flashrom/+/72807/comment/91193b4e_014f5a73 
PS3, Line 268: uint8_t
`const`?

https://review.coreboot.org/c/flashrom/+/72807/comment/5c30bcf0_8f017d2d 
PS3, Line 311: stored_delay_us
`delay_us`

https://review.coreboot.org/c/flashrom/+/72807/comment/810fdff2_aed49088 
PS3, Line 315: int
`unsigned int` ?

https://review.coreboot.org/c/flashrom/+/72807/comment/1caaccb1_b84b2414 
PS3, Line 323: i = 0
`unsigned int i = 0;`

https://review.coreboot.org/c/flashrom/+/72807/comment/178d376f_cd8784cf 
PS3, Line 365: nsigned int p;
delete

https://review.coreboot.org/c/flashrom/+/72807/comment/bac944ba_d7931173 
PS3, Line 366: p
actually should be `size_t p = 0;`

https://review.coreboot.org/c/flashrom/+/72807/comment/6aa60df7_80cda1ce 
PS3, Line 387: i
`unsigned int i`

https://review.coreboot.org/c/flashrom/+/72807/comment/a46a66f2_64abd509 
PS3, Line 419: 4 * 1024
`4*KiB` in another patch?

https://review.coreboot.org/c/flashrom/+/72807/comment/c7541d2b_05b52209 
PS3, Line 460: ret != 0
`ret`, C will auto-cast to make the predicate boolean.

https://review.coreboot.org/c/flashrom/+/72807/comment/9ad093f7_751ad0eb 
PS3, Line 465: (ret != 0)
`(ret)` is canonical.

https://review.coreboot.org/c/flashrom/+/72807/comment/4568ca26_e7dcad08 
PS3, Line 495: i
`int i` in another patch?

https://review.coreboot.org/c/flashrom/+/72807/comment/7cec1773_775c1af9 
PS3, Line 504: i = 0
ditto

https://review.coreboot.org/c/flashrom/+/72807/comment/571daf87_385f8c94 
PS3, Line 513: i = 0
ditto