Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.

View Change

17 comments:

• Patchset:

  • Patch Set #5:

    I added many cleanups you can do as a follow up patch to make type usage consistent, const correct and modern.

• File ch341a_spi.c:

  • Patch Set #3, Line 100: i = 0

    `size_t i = 0;`

  • Patch Set #3, Line 234: unsigned int i;

    delete

  • Patch Set #3, Line 235: i

    probably should be `size_t i = 0;`

  • Patch Set #3, Line 268: uint8_t

    `const`?

  • Patch Set #3, Line 311: stored_delay_us

    `delay_us`

  • Patch Set #3, Line 315: int

    `unsigned int` ?

  • Patch Set #3, Line 323: i = 0

    `unsigned int i = 0;`

  • Patch Set #3, Line 365: nsigned int p;

    delete

  • Patch Set #3, Line 366: p

    actually should be `size_t p = 0;`

  • Patch Set #3, Line 387: i

    `unsigned int i`

  • Patch Set #3, Line 419: 4 * 1024

    `4*KiB` in another patch?

  • Patch Set #3, Line 460: ret != 0

    `ret`, C will auto-cast to make the predicate boolean.

  • Patch Set #3, Line 465: (ret != 0)

    `(ret)` is canonical.

  • Patch Set #3, Line 495: i

    `int i` in another patch?

  • Patch Set #3, Line 504: i = 0

    ditto

  • Patch Set #3, Line 513: i = 0

    ditto

To view, visit change 72807. To unsubscribe, or for help writing mail filters, visit settings.