[XS] Change in flashrom[main]: Abandon (Unable to trick Jenkins to re-check after adding Signed-off-...

[Anton Samsonov (Code Review)]

Attention is currently required from: Angel Pons, Anton Samsonov, Thomas Heijligen.

Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79152?usp=email )

Change subject: Abandon (Unable to trick Jenkins to re-check after adding Signed-off-by) Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed
......................................................................

Patch Set 3:

(1 comment)

File Makefile:

https://review.coreboot.org/c/flashrom/+/79152/comment/61318b51_81d72eb6 :
PS2, Line 395: ifneq ($(VERSION_GIT),)
> Does this work properly when `VERSION_GIT` is not defined?

The neat part is that `VERSION_GIT` is *always* defined, according to GNU Make syntax:

Note that ifdef only tests whether a variable has a value. It does not expand the variable to see if that value is nonempty. Consequently, tests using ifdef return true for all definitions except those like foo =. To test for an empty value, use ifeq ($(foo),).