Attention is currently required from: Angel Pons, Anton Samsonov, Thomas Heijligen.
View Change
1 comment:
File Makefile:
Patch Set #2, Line 395: ifneq ($(VERSION_GIT),)
Does this work properly when `VERSION_GIT` is not defined?
The neat part is that `VERSION_GIT` is *always* defined, according to GNU Make syntax:
Note that ifdef only tests whether a variable has a value. It does not expand the variable to see if that value is nonempty. Consequently, tests using ifdef return true for all definitions except those like foo =. To test for an empty value, use ifeq ($(foo),).
To view, visit change 79152. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed
Gerrit-Change-Number: 79152
Gerrit-PatchSet: 3
Gerrit-Owner: Anton Samsonov <devel@zxlab.ru>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Anton Samsonov <contact-launchpad@zxlab.ru>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anton Samsonov <devel@zxlab.ru>
Gerrit-Comment-Date: Tue, 21 Nov 2023 11:50:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment