Attention is currently required from: Paul Menzel, Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54943 )
Change subject: Add AmigaOS suppport to flashrom ......................................................................
Patch Set 1: Code-Review+1
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/54943/comment/1541c8da_5b73dde0 PS1, Line 8:
How can this be tested? In QEMU?
I'm not sure if it's doable (licensing issues, maybe?), but it would be nice to add a target to util/manibuilder to build-test for AmigaOS.
File Makefile:
https://review.coreboot.org/c/flashrom/+/54943/comment/40641b8f_96cba8e5 PS1, Line 141: Bus Pirate, Serprog and PonyProg are not supported under AmigaOS (missing serial support). I'd rather not list all the programmers in the comment. Instead, I'd say something like this:
# AmigaOS is missing serial support, disable incompatible programmers
https://review.coreboot.org/c/flashrom/+/54943/comment/0f1aae50_7b64caf7 PS1, Line 157: # Digilent SPI, Dediprog, Developerbox, USB-Blaster, PICkit2, CH341A and FT2232 are not supported under AmigaOS (missing USB support). Same story here:
# AmigaOS is missing USB support, disable incompatible programmers
https://review.coreboot.org/c/flashrom/+/54943/comment/b9460cae_60a1f251 PS1, Line 213: DOS AmigaOS
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/54943/comment/b2517d92_28b543ab PS1, Line 162: *argv[] I guess this type is what makes AmigaOS unhappy?
File flash.h:
https://review.coreboot.org/c/flashrom/+/54943/comment/51d11540_5010b230 PS1, Line 55: wrong Out of curiosity, what does `PRIxPTR` get defined as?
https://review.coreboot.org/c/flashrom/+/54943/comment/9dd92f6b_c2996753 PS1, Line 56: __AMIGA__ Why not use `IS_AMIGA` here?