Attention is currently required from: Paul Menzel, Stefan Reinauer.

Patch set 1:Code-Review +1

7 comments:

Commit Message:
- Patch Set #1, Line 8:
  How can this be tested? In QEMU?
  I'm not sure if it's doable (licensing issues, maybe?), but it would be nice to add a target to util/manibuilder to build-test for AmigaOS.
File Makefile:
- Patch Set #1, Line 141: Bus Pirate, Serprog and PonyProg are not supported under AmigaOS (missing serial support).
  I'd rather not list all the programmers in the comment. Instead, I'd say something like this:
```
 # AmigaOS is missing serial support, disable incompatible programmers
```
- Patch Set #1, Line 157: # Digilent SPI, Dediprog, Developerbox, USB-Blaster, PICkit2, CH341A and FT2232 are not supported under AmigaOS (missing USB support).
  Same story here:
```
 # AmigaOS is missing USB support, disable incompatible programmers
```
- Patch Set #1, Line 213: DOS
  AmigaOS
File cli_classic.c:
- Patch Set #1, Line 162: *argv[]
  I guess this type is what makes AmigaOS unhappy?
File flash.h:
- Patch Set #1, Line 55: wrong
  Out of curiosity, what does `PRIxPTR` get defined as?
- Patch Set #1, Line 56: __AMIGA__
  Why not use `IS_AMIGA` here?

To view, visit change 54943. To unsubscribe, or for help writing mail filters, visit settings.