Attention is currently required from: Nico Huber, Daniel Campello, Angel Pons. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52362 )
Change subject: cli_classic: Make -r/-w/-v argument optional ......................................................................
Patch Set 1:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/52362/comment/04d0f4b0_7b0681d5 PS1, Line 46: I'm not too familiar with what the design considerations are here, so take this with a grain of salt, but I wonder if there is a way to make the flags more orthogonal. Right now, these two invocations would be equivalent: -r some_file.bin -i some_region -r -i some_region:some_file.bin
One option is to get rid of "-i" completely and make -r/-w/-v repeated with optional region parameters, e.g. something like -r some_file.bin -r some_file.bin:some_region -r some_file.bin:some_region -r some_other_file.bin:some_other_region
But if we need to keep "-i" around, then everything here seems reasonable.
-
Nikolai Artemiev (Code Review)