Attention is currently required from: Nico Huber, Daniel Campello, Angel Pons.
View Change
1 comment:
File cli_classic.c:
Patch Set #1, Line 46:
I'm not too familiar with what the design considerations are here, so take this with a grain of salt, but I wonder if there is a way to make the flags more orthogonal. Right now, these two invocations would be equivalent:
-r some_file.bin -i some_region
-r -i some_region:some_file.bin
One option is to get rid of "-i" completely and make -r/-w/-v repeated with optional region parameters, e.g. something like
-r some_file.bin
-r some_file.bin:some_region
-r some_file.bin:some_region -r some_other_file.bin:some_other_region
But if we need to keep "-i" around, then everything here seems reasonable.
To view, visit change 52362. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41
Gerrit-Change-Number: 52362
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Daniel Campello <campello@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 15 Apr 2021 04:48:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment