Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67664 )
Change subject: tests: add basic lifecycle test for ch341a_spi ......................................................................
Patch Set 9:
(2 comments)
File tests/ch341a_spi.c:
https://review.coreboot.org/c/flashrom/+/67664/comment/44ab14e7_ffde9cc7 PS5, Line 22: transfer->status = LIBUSB_TRANSFER_COMPLETED; : transfer->actual_length = transfer->length; : transfer->callback(transfer);
Thank you so much for the detailed explanation, I appreciate a lot! […]
Finally, I've wrote :D
File tests/ch341a_spi.c:
https://review.coreboot.org/c/flashrom/+/67664/comment/e7eed9cf_630a9e26 PS8, Line 38: if (transfer->endpoint == WRITE_EP)
Just wanted to mention: the assertion on the previous line makes sure this condition is always true. […]
I agree with your suggestion, let's add this piece of code in the next patch.