Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
View Change
2 comments:
File tests/ch341a_spi.c:
Patch Set #5, Line 22:
transfer->status = LIBUSB_TRANSFER_COMPLETED;
transfer->actual_length = transfer->length;
transfer->callback(transfer);
Thank you so much for the detailed explanation, I appreciate a lot! […]
Finally, I've wrote :D
File tests/ch341a_spi.c:
Patch Set #8, Line 38: if (transfer->endpoint == WRITE_EP)
Just wanted to mention: the assertion on the previous line makes sure this condition is always true. […]
I agree with your suggestion, let's add this piece of code in the next patch.
To view, visit change 67664. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If28fbe09ad685082152aa3a7e8d5a150169aee9e
Gerrit-Change-Number: 67664
Gerrit-PatchSet: 9
Gerrit-Owner: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Thu, 17 Nov 2022 16:30:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Alexander Goncharov <chat@joursoir.net>
Gerrit-MessageType: comment