Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55295 )
Change subject: tests: Do not build a test if its driver is not built ......................................................................
Patch Set 2:
(1 comment)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/55295/comment/e006ddeb_4f66cc6c PS1, Line 35: #if CONFIG_DUMMY == 1 : void dummy_init_and_shutdown_test_success(void **state) : { : run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi"); : } : #endif /* CONFIG_DUMMY */
I was going to wait for Thomas' patch series to be submitted first. […]
Right, this would actually benefit from removing the #if's from `programmer.h`. In theory this might work then:
if (CONFIG_DUMMY) run_lifecycle(state, programmer_dummy, "bus=parallel+lpc+fwh+spi");
Probably needs a linker flag, IIRC `--gc-sections`. The idea is that the code would get garbage collected in case `CONFIG_DUMMY == 0` and then the linker wouldn't have to complain about the missing `programmer_dummy`.