Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File tests/init_shutdown.c:

  • Patch Set #1, Line 35:

    #if CONFIG_DUMMY == 1
    void dummy_init_and_shutdown_test_success(void **state)
    {
    	run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi");
    }
    #endif /* CONFIG_DUMMY */
    

    I was going to wait for Thomas' patch series to be submitted first. […]

    Right, this would actually benefit from removing the #if's from `programmer.h`.
    In theory this might work then:

        if (CONFIG_DUMMY)
                run_lifecycle(state, programmer_dummy, "bus=parallel+lpc+fwh+spi");

    Probably needs a linker flag, IIRC `--gc-sections`. The idea is that the code
    would get garbage collected in case `CONFIG_DUMMY == 0` and then the linker
    wouldn't have to complain about the missing `programmer_dummy`.

To view, visit change 55295. To unsubscribe, or for help writing mail filters, visit settings.