Attention is currently required from: Edward O'Callaghan, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72408 )
Change subject: dummyflasher: use new API to register shutdown function ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/72408/comment/4466b9fc_d5a9d205 PS2, Line 1416: data->refs_cnt += ((dummy_buses_supported & BUS_PROG) != BUS_NONE); : data->refs_cnt += ((dummy_buses_supported & BUS_NONSPI) != BUS_NONE); : data->refs_cnt += ((dummy_buses_supported & BUS_SPI) != BUS_NONE); : : #if 0 : data->refs_cnt += (dummy_buses_supported & BUS_PROG) ? 1 : 0; : data->refs_cnt += (dummy_buses_supported & BUS_NONSPI) ? 1 : 0; : data->refs_cnt += (dummy_buses_supported & BUS_SPI) ? 1 : 0; : #endif
Your last idea is exactly what we need. […]
Done
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/72408/comment/11849093_8a4ab32e PS3, Line 966: .probe = probe_variable_size, : .read = dummy_opaque_read, : .write = dummy_opaque_write, : .erase = dummy_opaque_erase, : .shutdown = dummy_shutdown, : .delay = dummy_nop_delay, You need to align indentation (look at `=` sign), shutdown is the longest word and breaks the alignment.