Attention is currently required from: Edward O'Callaghan, Alexander Goncharov.

Patch set 3:Code-Review +1

View Change

2 comments:

• File dummyflasher.c:

  • Patch Set #2, Line 1416:

    data->refs_cnt += ((dummy_buses_supported & BUS_PROG) != BUS_NONE);
    	data->refs_cnt += ((dummy_buses_supported & BUS_NONSPI) != BUS_NONE);
    	data->refs_cnt += ((dummy_buses_supported & BUS_SPI) != BUS_NONE);
    
    #if 0
    	data->refs_cnt += (dummy_buses_supported & BUS_PROG) ? 1 : 0;
    	data->refs_cnt += (dummy_buses_supported & BUS_NONSPI) ? 1 : 0;
    	data->refs_cnt += (dummy_buses_supported & BUS_SPI) ? 1 : 0;
    #endif
    

    Your last idea is exactly what we need. […]

    Done

• File dummyflasher.c:

  • Patch Set #3, Line 966:

    	.probe	= probe_variable_size,
    	.read	= dummy_opaque_read,
    	.write	= dummy_opaque_write,
    	.erase	= dummy_opaque_erase,
    	.shutdown	= dummy_shutdown,
    	.delay	= dummy_nop_delay,
    

    You need to align indentation (look at `=` sign), shutdown is the longest word and breaks the alignment.

To view, visit change 72408. To unsubscribe, or for help writing mail filters, visit settings.