Attention is currently required from: Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62320 )
Change subject: tests/: Allow for file path validation ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62320/comment/503a8650_cf8f8ace PS4, Line 7: Allow for file path validation I added some comments about commit messages in previous patches, this one would need to be aligned as well. I prefer something like "Add support for multiple calls to open".
Also would be great to have some description, I would mention all tests except ABC are using the same mock function introduced earlier in the chain.
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/62320/comment/5d5b50ab_a88b57e4 PS4, Line 61: data Why dummy needs mocks? This is unexpected [to me].
https://review.coreboot.org/c/flashrom/+/62320/comment/565aed66_c1b1d7d5 PS4, Line 80: data Same comment as in previous patches: let's be more specific with naming and call this `nicrealtek_io_state`, and same for the rest of tests touched in the patch.
https://review.coreboot.org/c/flashrom/+/62320/comment/31fb95b7_a6100fe8 PS4, Line 89: Lets add new line before and after `io_mock_register`
https://review.coreboot.org/c/flashrom/+/62320/comment/d1ae56bf_e0baee43 PS4, Line 90: Since this test now registering io mock, it also needs to unregister, which is io_mock_register(NULL);
after running lifecycle. And same for all other tests touched by this patch.
Dediprog test is a good examples, it has all new lines and unregister.
-
Anastasia Klimchuk (Code Review)