Attention is currently required from: Edward O'Callaghan.

View Change

5 comments:

• Commit Message:

  • Patch Set #4, Line 7: Allow for file path validation

    I added some comments about commit messages in previous patches, this one would need to be aligned as well.
    I prefer something like "Add support for multiple calls to open".

    Also would be great to have some description, I would mention all tests except ABC are using the same mock function introduced earlier in the chain.

• File tests/init_shutdown.c:

  • Patch Set #4, Line 61: data

    Why dummy needs mocks? This is unexpected [to me].

  • Patch Set #4, Line 80: data

    Same comment as in previous patches: let's be more specific with naming and call this `nicrealtek_io_state`, and same for the rest of tests touched in the patch.

  • Patch Set #4, Line 89:

    Lets add new line before and after `io_mock_register`

  • Patch Set #4, Line 90:

    Since this test now registering io mock, it also needs to unregister, which is
     io_mock_register(NULL);

    after running lifecycle.
    And same for all other tests touched by this patch.

    Dediprog test is a good examples, it has all new lines and unregister.

To view, visit change 62320. To unsubscribe, or for help writing mail filters, visit settings.