Attention is currently required from: Dmitry Zhadinets.
Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/86875?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: libflashrom: Update the API for Logger Callback ......................................................................
libflashrom: Update the API for Logger Callback
The initial implementation does not account for user_data, requiring the calling application to use a global scope. This may lead to issues related to object lifecycle management and other architectural concerns.
This patch adds user_data to the user’s log callback. Moreover, it performs message formatting, so the application only needs to pass the formatted string to the selected output.
The change does not break the existing logging API but extends it. A new API version is introduced with the v2 suffix.
Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully.
Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Signed-off-by: Dmitry Zhadinets dzhadinets@gmail.com --- M include/libflashrom.h M libflashrom.c M libflashrom.map A tests/libflashrom.c M tests/meson.build M tests/tests.c M tests/tests.h 7 files changed, 141 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/86875/7