Attention is currently required from: Dmitry Zhadinets.

Dmitry Zhadinets uploaded patch set #7 to this change.

View Change

The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)

libflashrom: Update the API for Logger Callback

The initial implementation does not account for user_data, requiring
the calling application to use a global scope. This may lead to issues
related to object lifecycle management and other architectural
concerns.

This patch adds user_data to the user’s log callback. Moreover, it
performs message formatting, so the application only needs to pass
the formatted string to the selected output.

The change does not break the existing logging API but extends it.
A new API version is introduced with the v2 suffix.

Testing: Both unit tests and CLI tools serve as libflashrom clients.
All unit tests run successfully.

Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39
Signed-off-by: Dmitry Zhadinets <dzhadinets@gmail.com>
---
M include/libflashrom.h
M libflashrom.c
M libflashrom.map
A tests/libflashrom.c
M tests/meson.build
M tests/tests.c
M tests/tests.h
7 files changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/86875/7

To view, visit change 86875. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39
Gerrit-Change-Number: 86875
Gerrit-PatchSet: 7
Gerrit-Owner: Dmitry Zhadinets <dzhadinets@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Dmitry Zhadinets <dzhadinets@gmail.com>