Attention is currently required from: Wonkyu Kim, Subrata Banik, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62783 )
Change subject: ichspi: Add support for Meteor Lake ......................................................................
Patch Set 1: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62783/comment/828a4470_52ff49a8 PS1, Line 12: TEST= Could you also validate the chip detection logic just as we did in https://review.coreboot.org/c/flashrom/+/62251 so things like the `flashrom -p internal --ifd -i fd -i bios -r /tmp/filename.rom` test.
Just don't want to repeat anything learnings from that patch?
https://review.coreboot.org/c/flashrom/+/62783/comment/4789b378_a273a71c PS1, Line 18: rom : the chipset name. line wrap.
Patchset:
PS1: Thank you for the patch and upstreaming this work Subrata.
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/d04a8d85_1467358f PS1, Line 1048: if (content->CSSL == 0x03) { : if (content->CSSO == 0x70) : return CHIPSET_METEOR_LAKE; Can you elaborate on this part in the commit message to justify this will not regress Elkhart Lake detection logic? Do we have one of those to test with as well?
-
Edward O'Callaghan (Code Review)