Attention is currently required from: Wonkyu Kim, Subrata Banik, Anastasia Klimchuk.

Patch set 1:Code-Review +2

4 comments:

Commit Message:
- Patch Set #1, Line 12: TEST=
  Could you also validate the chip detection logic just as we did in https://review.coreboot.org/c/flashrom/+/62251 so things like the `flashrom -p internal --ifd -i fd -i bios -r /tmp/filename.rom` test.
  Just don't want to repeat anything learnings from that patch?
- Patch Set #1, Line 18:
```
rom
the chipset name.
```
  line wrap.
Patchset:
- Patch Set #1:
  Thank you for the patch and upstreaming this work Subrata.
File ich_descriptors.c:
- Patch Set #1, Line 1048:
```
		if (content->CSSL == 0x03) {
			if (content->CSSO == 0x70)
				return CHIPSET_METEOR_LAKE;
```
  Can you elaborate on this part in the commit message to justify this will not regress Elkhart Lake detection logic? Do we have one of those to test with as well?

To view, visit change 62783. To unsubscribe, or for help writing mail filters, visit settings.