Change in ...flashrom[master]: flashchips.c: Replace comment with #if 0

List overview All Threads
Download

newer

older

Change in flashrom[master]:...

Change in ...flashrom[master]:...

Alan Green (Code Review)

27 Jun 2019 27 Jun '19

9:03 a.m.

Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33836

Change subject: flashchips.c: Replace comment with #if 0 ......................................................................

flashchips.c: Replace comment with #if 0

To allow better handling by automated tools, replace /* */ commenting out a whole entry with #if 0 / #endif

Signed-off-by: Alan Green avg@google.com Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 --- M flashchips.c 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/33836/1

diff --git a/flashchips.c b/flashchips.c index e421c4c..7f3d2a2 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2511,7 +2511,8 @@ },

/*The AT26DF321 has the same ID as the AT25DF321. */ - /*{ +#if 0 + { .vendor = "Atmel", .name = "AT26DF321", .bustype = BUS_SPI, @@ -2527,7 +2528,8 @@ .unlock = spi_disable_blockprotect, .write = spi_chip_write_256, .read = spi_chip_read, - },*/ + }, +#endif

{ .vendor = "Atmel",

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Alan Green (Code Review)

28 Jun 28 Jun

1:42 a.m.

Hello Edward O'Callaghan, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/33836

to look at the new patch set (#2).

Change subject: flashchips.c: Replace comment with #if 0 ......................................................................

flashchips.c: Replace comment with #if 0

To allow better handling by automated tools, replace /* */ commenting out a whole entry with #if 0 / #endif

Signed-off-by: Alan Green avg@google.com Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 --- M flashchips.c 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/33836/2

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Alan Green (Code Review)

2:18 a.m.

Hello Edward O'Callaghan, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/33836

to look at the new patch set (#3).

Change subject: flashchips.c: Replace comment with #if 0 ......................................................................

flashchips.c: Replace comment with #if 0

To allow better handling by automated tools, replace /* */ commenting out a whole entry with #if 0 / #endif

Signed-off-by: Alan Green avg@google.com Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 --- M flashchips.c 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/33836/3

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Alan Green (Code Review)

5:36 a.m.

Hello Edward O'Callaghan, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/33836

to look at the new patch set (#4).

Change subject: flashchips.c: Replace comment with #if 0 ......................................................................

flashchips.c: Replace comment with #if 0

To allow better handling by automated tools, replace /* */ commenting out a whole entry with #if 0 / #endif

Signed-off-by: Alan Green avg@google.com Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 --- M flashchips.c 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/33836/4

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 4 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

2 Jul 2 Jul

3 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips.c: Replace comment with #if 0 ......................................................................

Patch Set 5: Code-Review+2

Not sure if this entry should just be removed.

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 5 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 01:00:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

5:47 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips.c: Replace comment with #if 0 ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 5 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 03:47:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Alan Green (Code Review)

6:11 a.m.

Hello Edward O'Callaghan, Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/33836

to look at the new patch set (#6).

Change subject: flashchips.c: Replace comment with #if 0 ......................................................................

flashchips.c: Replace comment with #if 0

To allow better handling by automated tools, replace /* */ commenting out a whole entry with #if 0 / #endif

Signed-off-by: Alan Green avg@google.com Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 --- M flashchips.c 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/33836/6

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 6 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

12:09 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips.c: Replace comment with #if 0 ......................................................................

Patch Set 7:

...

Not sure if this entry should just be removed.

I agree, it should either be finished (i.e. add erasers and voltage range) or just dropped. The comment could be moved to AT25DF321 in the latter case.

If the datasheet is available, I would prefer to make it whole entry.

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 7 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 10:09:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

12:25 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips.c: Replace comment with #if 0 ......................................................................

Patch Set 7:

...

Patch Set 7:

...
Not sure if this entry should just be removed.

I agree, it should either be finished (i.e. add erasers and voltage range) or just dropped. The comment could be moved to AT25DF321 in the latter case.

If the datasheet is available, I would prefer to make it whole entry.

Looks like the datasheet exists: https://cdn.hackaday.io/files/7758331918272/AT26DF321.pdf

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 7 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 10:25:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Alan Green (Code Review)

3 Jul 3 Jul

6:57 a.m.

Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips.c: Replace comment with #if 0 ......................................................................

Patch Set 7:

...

Patch Set 7:

...
Patch Set 7:

...
Not sure if this entry should just be removed.

I agree, it should either be finished (i.e. add erasers and voltage range) or just dropped. The comment could be moved to AT25DF321 in the latter case.

If the datasheet is available, I would prefer to make it whole entry.

Looks like the datasheet exists: https://cdn.hackaday.io/files/7758331918272/AT26DF321.pdf

It looks as though the AT26DF321 is marked obsolete by Digikey and not really mentioned on Atmel's site. Since we've done without a working definition for this long, I'll just remove it for now and move the comment about same ID to the AT25DF321 entry.

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 7 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jul 2019 04:57:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Alan Green (Code Review)

7:18 a.m.

New subject: Change in ...flashrom[master]: flashchips: Drop dead code of AT26DF321

Hello Edward O'Callaghan, Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/33836

to look at the new patch set (#8).

Change subject: flashchips: Drop dead code of AT26DF321 ......................................................................

flashchips: Drop dead code of AT26DF321

The definition for the AT26DF321 has been commented out since it was first added in 2008. The chip now appears to be obsolete, being marked "obsolete" and unstocked at Digikey. It is also only referred to in historical documents on the manufacturer's website (microchip.com).

To avoid further bitrot of this dead code, drop it.

Signed-off-by: Alan Green avg@google.com Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 --- M flashchips.c 1 file changed, 1 insertion(+), 19 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/33836/8

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 8 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Edward O'Callaghan (Code Review)

9:06 a.m.

New subject: Change in ...flashrom[master]: flashchips: Drop dead code of AT26DF321

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips: Drop dead code of AT26DF321 ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 8 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jul 2019 07:06:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

10:51 a.m.

New subject: Change in ...flashrom[master]: flashchips: Drop dead code of AT26DF321

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips: Drop dead code of AT26DF321 ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 8 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jul 2019 08:51:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

10:54 a.m.

New subject: Change in ...flashrom[master]: flashchips: Drop dead code of AT26DF321

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips: Drop dead code of AT26DF321 ......................................................................

Patch Set 8: Code-Review-1

(1 comment)

Oops, missed flashchips.h

https://review.coreboot.org/#/c/33836/8/flashchips.c File flashchips.c:

https://review.coreboot.org/#/c/33836/8/flashchips.c@a2519 PS8, Line 2519: This needs to be dropped too, in flashchips.h

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 8 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jul 2019 08:54:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Alan Green (Code Review)

4 Jul 4 Jul

6:17 a.m.

New subject: Change in flashrom[master]: flashchips: Drop dead code of AT26DF321

Hello Edward O'Callaghan, Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/33836

to look at the new patch set (#9).

Change subject: flashchips: Drop dead code of AT26DF321 ......................................................................

flashchips: Drop dead code of AT26DF321

To avoid further bitrot of this dead code, drop it.

Signed-off-by: Alan Green avg@google.com Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 --- M flashchips.c M flashchips.h 2 files changed, 1 insertion(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/33836/9

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 9 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Alan Green (Code Review)

6:19 a.m.

New subject: Change in flashrom[master]: flashchips: Drop dead code of AT26DF321

Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips: Drop dead code of AT26DF321 ......................................................................

Patch Set 9:

(2 comments)

...

Patch Set 8: Code-Review-1

(1 comment)

Oops, missed flashchips.h

Thanks!

https://review.coreboot.org/c/flashrom/+/33836/9/flashchips.h File flashchips.h:

https://review.coreboot.org/c/flashrom/+/33836/9/flashchips.h@136 PS9, Line 136: /* Same as 26DF321 */ I intentionally left this comment here since it matches the comment on the AT25DF321 entry in flashchips.c.

https://review.coreboot.org/c/flashrom/+/33836/8/flashchips.c File flashchips.c:

https://review.coreboot.org/c/flashrom/+/33836/8/flashchips.c@a2519 PS8, Line 2519:

...

This needs to be dropped too, in flashchips. […]

Done

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 9 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jul 2019 04:19:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

6:28 a.m.

New subject: Change in flashrom[master]: flashchips: Drop dead code of AT26DF321

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips: Drop dead code of AT26DF321 ......................................................................

Patch Set 9: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 9 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jul 2019 04:28:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

6:29 a.m.

New subject: Change in flashrom[master]: flashchips: Drop dead code of AT26DF321

Edward O'Callaghan has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips: Drop dead code of AT26DF321 ......................................................................

flashchips: Drop dead code of AT26DF321

To avoid further bitrot of this dead code, drop it.

Signed-off-by: Alan Green avg@google.com Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Reviewed-on: https://review.coreboot.org/c/flashrom/+/33836 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M flashchips.c M flashchips.h 2 files changed, 1 insertion(+), 20 deletions(-)

Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved

diff --git a/flashchips.c b/flashchips.c index f3aab52..ac65510 100644 --- a/flashchips.c +++ b/flashchips.c @@ -1709,6 +1709,7 @@ .voltage = {2700, 3600}, },

+ /*The AT26DF321 has the same ID as the AT25DF321. */ { .vendor = "Atmel", .name = "AT25DF321", @@ -2510,25 +2511,6 @@ .voltage = {2700, 3600}, },

- /*The AT26DF321 has the same ID as the AT25DF321. */ - /*{ - .vendor = "Atmel", - .name = "AT26DF321", - .bustype = BUS_SPI, - .manufacture_id = ATMEL_ID, - .model_id = ATMEL_AT26DF321, - .total_size = 4096, - .page_size = 256, - .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_UNTESTED, - .probe = probe_spi_rdid, - .probe_timing = TIMING_ZERO, - .printlock = spi_prettyprint_status_register_at26df081a, - .unlock = spi_disable_blockprotect, - .write = spi_chip_write_256, - .read = spi_chip_read, - },*/ - { .vendor = "Atmel", .name = "AT26F004", diff --git a/flashchips.h b/flashchips.h index a1b38e0..1c7ba99 100644 --- a/flashchips.h +++ b/flashchips.h @@ -156,7 +156,6 @@ #define ATMEL_AT26DF081A 0x4501 #define ATMEL_AT26DF161 0x4600 #define ATMEL_AT26DF161A 0x4601 -#define ATMEL_AT26DF321 0x4700 /* Same as 25DF321 */ #define ATMEL_AT26F004 0x0400 #define ATMEL_AT29LV512 0x3D #define ATMEL_AT29LV010A 0x35 /* Same as AT29BV010A, the latter works down to 2.7V */

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 10 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

Angel Pons (Code Review)

11:31 a.m.

New subject: Change in flashrom[master]: flashchips: Drop dead code of AT26DF321

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )

Change subject: flashchips: Drop dead code of AT26DF321 ......................................................................

Patch Set 10: Code-Review+2

(1 comment)

I know it's submitted already, but wanted to state that LGTM.

https://review.coreboot.org/c/flashrom/+/33836/9/flashchips.h File flashchips.h:

https://review.coreboot.org/c/flashrom/+/33836/9/flashchips.h@136 PS9, Line 136: /* Same as 26DF321 */

...

I intentionally left this comment here since it matches the comment on the AT25DF321 entry in flashc […]

Yep, that's perfectly fine.

-- To view, visit https://review.coreboot.org/c/flashrom/+/33836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Gerrit-Change-Number: 33836 Gerrit-PatchSet: 10 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jul 2019 09:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Alan Green avg@google.com Gerrit-MessageType: comment

1998

days inactive

2005

days old

flashrom-gerrit@flashrom.org

18 comments

4 participants

tags (0)

participants (4)

Alan Green (Code Review)
Angel Pons (Code Review)
Edward O'Callaghan (Code Review)
Nico Huber (Code Review)