Patch Set 7:

Patch Set 7:

Not sure if this entry should just be removed.

I agree, it should either be finished (i.e. add erasers
and voltage range) or just dropped. The comment could be
moved to AT25DF321 in the latter case.

If the datasheet is available, I would prefer to make
it whole entry.

Looks like the datasheet exists: https://cdn.hackaday.io/files/7758331918272/AT26DF321.pdf

It looks as though the AT26DF321 is marked obsolete by Digikey and not really mentioned on Atmel's site. Since we've done without a working definition for this long, I'll just remove it for now and move the comment about same ID to the AT25DF321 entry.

View Change

To view, visit change 33836. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384
Gerrit-Change-Number: 33836
Gerrit-PatchSet: 7
Gerrit-Owner: Alan Green <avg@google.com>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 03 Jul 2019 04:57:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment