Attention is currently required from: Anastasia Klimchuk, Angel Pons, Artur Kowalski, ServError.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68557?usp=email )
Change subject: flashchips: add support for MX77L25650F chip ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68557/comment/dd4505cd_e2a5c70c : PS4, Line 11: can't disable it
can't enable it […]
I think he meant that if WP is enabled, `flashrom` won't be able to disable it to perform write/erase.
Patchset:
PS4:
@ServError, since your patch is more complete, do you want to update this one? You would do that by […]
I updated the patch.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/68557/comment/36baea18_0006743f : PS4, Line 10428: .vendor = "Macronix",
The values need to be tab-aligned, see the other entries.
Done
https://review.coreboot.org/c/flashrom/+/68557/comment/6243f628_42124f37 : PS4, Line 10449: // TODO: add support for flash protection
I don't think we need this TODO is the code. […]
Quite a lot of other chips have TODOs.
https://review.coreboot.org/c/flashrom/+/68557/comment/79900c22_20e57da7 : PS4, Line 10452: },
The voltage is missing?
Done
-
Sergii Dmytruk (Code Review)