[S] Change in flashrom[master]: cli_classic.c: Early init of layout obscures invalid memory access

[Angel Pons (Code Review)]

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67723 )

Change subject: cli_classic.c: Early init of layout obscures invalid memory access
......................................................................

Patch Set 2: Code-Review-1

(2 comments)

File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/67723/comment/baf5c132_77550e60 
PS2, Line 541: 	struct flashrom_layout *layout = NULL;
This means "no layout", which is true: initially, the flashrom classic CLI doesn't have any layout to work with, yet. If you don't initialize this variable, it has no meaning: it's impossible to check if a variable has been initialized or not, and relying on compiler warnings is something I'd prefer not to do.

https://review.coreboot.org/c/flashrom/+/67723/comment/41d15ca8_55748353 
PS2, Line 1110: 		msg_gdbg("Valid layout could not be found without image.\n");
What does this message even mean?