Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.

Patch set 2:Code-Review -1

View Change

2 comments:

• File cli_classic.c:

  • Patch Set #2, Line 541: struct flashrom_layout *layout = NULL;

    This means "no layout", which is true: initially, the flashrom classic CLI doesn't have any layout to work with, yet. If you don't initialize this variable, it has no meaning: it's impossible to check if a variable has been initialized or not, and relying on compiler warnings is something I'd prefer not to do.

  • Patch Set #2, Line 1110: msg_gdbg("Valid layout could not be found without image.\n");

    What does this message even mean?

To view, visit change 67723. To unsubscribe, or for help writing mail filters, visit settings.