[S] Change in flashrom[main]: flashchips: Add write-protect support for GD25LQ255E

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: David Wu, Hsuan-ting Chen, Kapil Porwal, Lean Sheng Tan, Nikolai Artemiev, Subrata Banik, Tyler Wang.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79460?usp=email )

Change subject: flashchips: Add write-protect support for GD25LQ255E
......................................................................


Patch Set 4:

(1 comment)

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/79460/comment/593504d5_00c5374c :
PS1, Line 6560: TEST_OK_PREW
> If you are able to test it (e.g. run `flashrom_tester`), please update this.
> That's a great point! Typically `.reg_bits` are added when someone started using write-protect and tested that it works.

Tyler, maybe you can tell us about it. If you are using write-protect for this chip then you can add the list of commands you were running [successfully] to the commit message. It is important to share the relevant testing info for each commit. Thanks!



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/79460?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I1425e931433c00caceaabc6037a79099d6d5eac5
Gerrit-Change-Number: 79460
Gerrit-PatchSet: 4
Gerrit-Owner: Tyler Wang <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: David Wu <[e-mail]>
Gerrit-Reviewer: Hsuan-ting Chen <[e-mail]>
Gerrit-Reviewer: Kapil Porwal <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: Stefan Reinauer <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Subrata Banik <[e-mail]>
Gerrit-Attention: David Wu <[e-mail]>
Gerrit-Attention: Subrata Banik <[e-mail]>
Gerrit-Attention: Hsuan-ting Chen <[e-mail]>
Gerrit-Attention: Kapil Porwal <[e-mail]>
Gerrit-Attention: Tyler Wang <[e-mail]>
Gerrit-Attention: Lean Sheng Tan <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-Comment-Date: Sat, 16 Dec 2023 11:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <[e-mail]>
Gerrit-MessageType: comment