Attention is currently required from: David Wu, Hsuan-ting Chen, Kapil Porwal, Lean Sheng Tan, Nikolai Artemiev, Subrata Banik, Tyler Wang.
View Change
1 comment:
File flashchips.c:
Patch Set #1, Line 6560: TEST_OK_PREW
If you are able to test it (e.g. run `flashrom_tester`), please update this.
That's a great point! Typically `.reg_bits` are added when someone started using write-protect and tested that it works.
Tyler, maybe you can tell us about it. If you are using write-protect for this chip then you can add the list of commands you were running [successfully] to the commit message. It is important to share the relevant testing info for each commit. Thanks!
To view, visit change 79460. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I1425e931433c00caceaabc6037a79099d6d5eac5
Gerrit-Change-Number: 79460
Gerrit-PatchSet: 4
Gerrit-Owner: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Sat, 16 Dec 2023 11:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <roccochen@google.com>
Gerrit-MessageType: comment