Attention is currently required from: Simon Buhrow, Nico Huber, Paul Menzel, Edward O'Callaghan.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 )
Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks
......................................................................
Patch Set 41:
(3 comments)
Patchset:
PS41:
a
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65879/comment/73dc7190_8864ddcc
PS41, Line 1226: static void free_erase_layout(struct erase_layout *layout, int erasefn_count);
you can drop this line, no need to forward declarate a static function like this.
Done
https://review.coreboot.org/c/flashrom/+/65879/comment/bd23bddf_df90129c
PS41, Line 1237:
: struct erase_layout *create_erase_layout(struct flashctx *const flashctx);
:
maybe put these prototypes into a header.
This function later becomes a static. Which header should I put it in?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/65879
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4
Gerrit-Change-Number: 65879
Gerrit-PatchSet: 41
Gerrit-Owner: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Sat, 10 Dec 2022 21:26:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment