Attention is currently required from: Simon Buhrow, Nico Huber, Paul Menzel, Edward O'Callaghan.

View Change

3 comments:

• Patchset:

  • Patch Set #41:

    a

• File flashrom.c:

  • Patch Set #41, Line 1226: static void free_erase_layout(struct erase_layout *layout, int erasefn_count);

    you can drop this line, no need to forward declarate a static function like this.

    Done

  • Patch Set #41, Line 1237:

    
    struct erase_layout *create_erase_layout(struct flashctx *const flashctx);
    
    

    maybe put these prototypes into a header.

    This function later becomes a static. Which header should I put it in?

To view, visit change 65879. To unsubscribe, or for help writing mail filters, visit settings.