Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58738 )
Change subject: cli_classic: add writeprotect CLI ......................................................................
Patch Set 7:
(4 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/58738/comment/b4ba353a_4a3bb1a2 PS7, Line 63: mode What <mode> is? I think this needs explanation, if someone runs `flashrom -h` they need to be able to understand how to use flashrom wp feature
https://review.coreboot.org/c/flashrom/+/58738/comment/69c3b3a1_86cd318f PS7, Line 222: if (!any_wp_op) return 0; any_wp_op seems like a duplication of information, you could check if any of commands is present?
https://review.coreboot.org/c/flashrom/+/58738/comment/16eb9ad8_c62c05c1 PS7, Line 257: return ret; Please move conditional body on the new line (and same for all other occurrences like this).
https://review.coreboot.org/c/flashrom/+/58738/comment/b7601add_eb54b7fa PS7, Line 920: goto out_release; and the ones like this too, please move on a new line
-
Anastasia Klimchuk (Code Review)