Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk.

View Change

4 comments:

• File cli_classic.c:

  • Patch Set #7, Line 63: mode

    What <mode> is? I think this needs explanation, if someone runs `flashrom -h` they need to be able to understand how to use flashrom wp feature

  • Patch Set #7, Line 222: if (!any_wp_op) return 0;

    any_wp_op seems like a duplication of information, you could check if any of commands is present?

  • Patch Set #7, Line 257: return ret;

    Please move conditional body on the new line (and same for all other occurrences like this).

  • Patch Set #7, Line 920: goto out_release;

    and the ones like this too, please move on a new line

To view, visit change 58738. To unsubscribe, or for help writing mail filters, visit settings.