Change in flashrom[master]: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )

Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call
......................................................................

Patch Set 14: Code-Review+1

(3 comments)
> Patch Set 14:
>
> @AngelPons:
> Would be great to get some feedback and/or get this merged. See my last post to get a quick overview of this change.

Sorry, I've forgotten about these changes. I'll take a look as soon as I can, because it's been a long while.

https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c 
File ft2232_spi.c:

https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c@473 
PS8, Line 473: static
> This is related to Line 541 and following lines. It is explained (shortly) in Line 542. […]

Ack

https://review.coreboot.org/c/flashrom/+/40477/14/ft2232_spi.c 
File ft2232_spi.c:

https://review.coreboot.org/c/flashrom/+/40477/14/ft2232_spi.c@480 
PS14, Line 480: /*
              : 		* 280 bytes =
              : 		*   + 9 B (CMD)
              : 		*   + 1 B (WREN)
              : 		*   + 9 B (CMD)
              : 		*   + 1 B (op)          \
              : 		*   + 4 B (addr)        | = writecnt
              : 		*   + 256 B (page data) /
              : 		*
              : 		* With op: PageProgram or Erase; CMD: FTDI-Chip commands
              : 		*/
nit: I'd place this before the assignment to `bufsize`. And please align correctly (there's one tab too many)

https://review.coreboot.org/c/flashrom/+/40477/14/ft2232_spi.c@555 
PS14, Line 555: /* Return to get second op (Program or Erase) without
              : 		 * resetting buf nor i*/
Comment style should be:

/*
  * Return to get second op (Program or Erase)
  * without resetting buf nor i
  */