[XS] Change in flashrom[main]: flashrom_tester: Correct "WP screw" message

[Hsuan-ting Chen (Code Review)]

Attention is currently required from: Angel Pons, Brian Norris, Thomas Heijligen.

Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82083?usp=email )

Change subject: flashrom_tester: Correct "WP screw" message
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS5: 
More references here:

1. This message should only be shown if the tester noticed that the current status of hardware writeprotection is not at the expected value.
> a. If the current HWWP is enable, but we need it to be disable:
2024-01-24T06:22:51.035812Z [ INFO ] Prompt for hardware WP disable
 > disconnect the battery (and/or open the WP screw)
Press enter to continue...

> b. If the current HWWP is disable, but we need it to be enable:
2024-01-24T06:21:47.737144Z [ INFO ] Prompt for hardware WP able
 > connect the battery (and/or open the WP screw)
Press enter to continue...

---

In ChromeOS, we usually modify the hardware writeprotection by:

1. Connect/Disconnect the battery
2. Remove/Restore the WP screw (Only for older devices)
3. Leveraging some Google Security Chip (GSC) Case Closed Debugging (CCD) commands (newer devices)


What about

`use the designated command, disconnect the battery, and/or remove the WP screw`

and

`use the designated command, connect the battery, and/or restore the WP screw`

Since IMO they are sorted by the frequency in real world usecase.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/82083?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270
Gerrit-Change-Number: 82083
Gerrit-PatchSet: 5
Gerrit-Owner: Brian Norris <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Evan Benn <[e-mail]>
Gerrit-Reviewer: Hsuan-ting Chen <[e-mail]>
Gerrit-Reviewer: Thomas Heijligen <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Brian Norris <[e-mail]>
Gerrit-Attention: Thomas Heijligen <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Comment-Date: Tue, 30 Apr 2024 12:26:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <[e-mail]>
Comment-In-Reply-To: Angel Pons <[e-mail]>
Gerrit-MessageType: comment