Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 )
Change subject: hwaccess_x86_io: clean header concept ......................................................................
Patch Set 15: Code-Review+2
(3 comments)
Patchset:
PS15: Wasn't this fixing Android? That could be added to the commit message.
File hwaccess_x86_io.h:
https://review.coreboot.org/c/flashrom/+/61276/comment/33d5b12c_691053ba PS15, Line 57: #define INL(x) __extension__ ({ u_int inl_tmp = (x); inl(inl_tmp); }) I really wonder why we did this odd dance. Could be something with macros that assumed they can reference the argument (i.e. create a pointer with &). Was added in commit 65c1b86fe (Changes to make flashrom compile (and work) on FreeBSD), review turned out to be on the coreboot mailing list, but I couldn't find any discussion.
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/6068b965_2cecfcde PS15, Line 31: * - USE_LIBC_LAST : * - USE_LIBC_FIRST Highlighted the identifiers in my editor, and taadaa the most errors are in comments as usual :)
Needs _TARGET update.
-
Nico Huber (Code Review)