Attention is currently required from: Thomas Heijligen.

Patch set 15:Code-Review +2

3 comments:

Patchset:
- Patch Set #15:
  Wasn't this fixing Android? That could be added to the commit message.
File hwaccess_x86_io.h:
- Patch Set #15, Line 57: #define INL(x) __extension__ ({ u_int inl_tmp = (x); inl(inl_tmp); })
  I really wonder why we did this odd dance. Could be something with macros
  that assumed they can reference the argument (i.e. create a pointer with &).
  Was added in commit 65c1b86fe (Changes to make flashrom compile (and work)
  on FreeBSD), review turned out to be on the coreboot mailing list, but
  I couldn't find any discussion.
File hwaccess_x86_io.c:
- Patch Set #15, Line 31:
```
 *   - USE_LIBC_LAST
 *   - USE_LIBC_FIRST
```
  Highlighted the identifiers in my editor, and taadaa the most errors are
  in comments as usual :)
  Needs _TARGET update.

To view, visit change 61276. To unsubscribe, or for help writing mail filters, visit settings.