[M] Change in flashrom[master]: test_build.sh: Build all programmers individually using Meson
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66475 )
Change subject: test_build.sh: Build all programmers individually using Meson ......................................................................
Patch Set 16:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66475/comment/da884bd3_c3ed1397 PS16, Line 12: the programmer groups individually.
I don't quite understand. What could lead to break the groups if […]
They are separate options. I would like to build-test all of them.
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/66475/comment/07145705_bdc4faff PS15, Line 57: # In case of clang analyzer we don't want to run it on
I wanted to avoid that and I didn't find another way than doing this. […]
Of course a function would work here, but it also seemed too much for me and so I decided against it. However, I can create a patch if you would like to have it this way.
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/66475/comment/2bb8fc37_3a98967b PS16, Line 15: auto
Why have `auto` here?
See my other comment.
-
Felix Singer (Code Review)