View Change
3 comments:
Commit Message:
Patch Set #16, Line 12: the programmer groups individually.
I don't quite understand. What could lead to break the groups if […]
They are separate options. I would like to build-test all of them.
File test_build.sh:
Patch Set #15, Line 57: # In case of clang analyzer we don't want to run it on
> I wanted to avoid that and I didn't find another way than doing this. […]
Of course a function would work here, but it also seemed too much for me and so I decided against it. However, I can create a patch if you would like to have it this way.
File test_build.sh:
To view, visit change 66475. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4
Gerrit-Change-Number: 66475
Gerrit-PatchSet: 16
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <patrick@coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 23 Sep 2022 22:45:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Patrick Georgi <patrick@coreboot.org>
Gerrit-MessageType: comment