Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57326 )
Change subject: tests: Add tests to read from chip ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/57326/comment/198dbcb9_4301177b PS1, Line 246: };
Yes right, they started to repeat once more tests have been added. I created CB:57437 for this.
Thanks. Often it's better to clean up first, though. Doesn't matter for this chain anymore ;) My rule of thumb: if you have to touch many lines again later in the chain, the order is probably wrong.
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/57326/comment/53985f31_e98f9d1f PS3, Line 185: len This is `nmemb` (according to manpage). `len` is easy to confuse with a length in bytes.
https://review.coreboot.org/c/flashrom/+/57326/comment/3c8d2e0e_cfa0d517 PS3, Line 188: size * len This should return just `len` (actually `nmemb`). It only works because flashrom passes 1 as `size`.
-
Nico Huber (Code Review)