Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

Patch set 3:Code-Review +1

View Change

3 comments:

• File tests/chip.c:

  • Patch Set #1, Line 246: };

    Yes right, they started to repeat once more tests have been added. I created CB:57437 for this.

    Thanks. Often it's better to clean up first, though. Doesn't matter for this
    chain anymore ;) My rule of thumb: if you have to touch many lines again later
    in the chain, the order is probably wrong.

• File tests/tests.c:

  • Patch Set #3, Line 185: len

    This is `nmemb` (according to manpage). `len` is easy to confuse with
    a length in bytes.

  • Patch Set #3, Line 188: size * len

    This should return just `len` (actually `nmemb`). It only works because
    flashrom passes 1 as `size`.

To view, visit change 57326. To unsubscribe, or for help writing mail filters, visit settings.